From a845925f99d6d7f2da1e8f86321cd3336275a66c Mon Sep 17 00:00:00 2001 From: Mattrixwv Date: Sat, 20 Aug 2022 13:54:26 -0400 Subject: [PATCH] Fix sonarqube findings --- src/main/java/com/mattrixwv/Triple.java | 3 +-- .../com/mattrixwv/generators/HexagonalNumberGenerator.java | 2 +- .../com/mattrixwv/generators/PentagonalNumberGenerator.java | 2 +- .../com/mattrixwv/generators/TriangularNumberGenerator.java | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/mattrixwv/Triple.java b/src/main/java/com/mattrixwv/Triple.java index e5b74e8..2958e4b 100644 --- a/src/main/java/com/mattrixwv/Triple.java +++ b/src/main/java/com/mattrixwv/Triple.java @@ -48,8 +48,7 @@ public class Triple{ if(this == o){ return true; } - else if(o instanceof Triple){ - Triple rightSide = (Triple)o; + else if(o instanceof Triple rightSide){ return (a.equals(rightSide.a) && b.equals(rightSide.b) && c.equals(rightSide.c)); } else{ diff --git a/src/main/java/com/mattrixwv/generators/HexagonalNumberGenerator.java b/src/main/java/com/mattrixwv/generators/HexagonalNumberGenerator.java index e516b65..9429a2f 100644 --- a/src/main/java/com/mattrixwv/generators/HexagonalNumberGenerator.java +++ b/src/main/java/com/mattrixwv/generators/HexagonalNumberGenerator.java @@ -51,7 +51,7 @@ public class HexagonalNumberGenerator implements Iterator{ } public static boolean isHexagonal(Long x){ - Long n = Math.round((Math.sqrt(1 + (8 * x)) + 1) / 4); + Long n = Math.round((Math.sqrt(1.0 + (8 * x)) + 1) / 4); return ((2 * n * n) - n) == x; } } diff --git a/src/main/java/com/mattrixwv/generators/PentagonalNumberGenerator.java b/src/main/java/com/mattrixwv/generators/PentagonalNumberGenerator.java index 1d9d19e..5394ad0 100644 --- a/src/main/java/com/mattrixwv/generators/PentagonalNumberGenerator.java +++ b/src/main/java/com/mattrixwv/generators/PentagonalNumberGenerator.java @@ -51,7 +51,7 @@ public class PentagonalNumberGenerator implements Iterator{ } public static boolean isPentagonal(Long x){ - Long n = Math.round((Math.sqrt(1 + (24 * x)) + 1) / 6); + Long n = Math.round((Math.sqrt(1.0 + (24 * x)) + 1) / 6); return (((3 * n * n) - n) / 2) == x; } } diff --git a/src/main/java/com/mattrixwv/generators/TriangularNumberGenerator.java b/src/main/java/com/mattrixwv/generators/TriangularNumberGenerator.java index bbcb524..d871d69 100644 --- a/src/main/java/com/mattrixwv/generators/TriangularNumberGenerator.java +++ b/src/main/java/com/mattrixwv/generators/TriangularNumberGenerator.java @@ -51,7 +51,7 @@ public class TriangularNumberGenerator implements Iterator{ } public static boolean isTriangular(Long x){ - Long n = Math.round((Math.sqrt(1 + (8 * x)) - 1) / 2); + Long n = Math.round((Math.sqrt(1.0 + (8 * x)) - 1) / 2); return (((n * n) + n) / 2) == x; } }