Fix sonarqube issues

This commit is contained in:
2026-01-26 22:23:05 -05:00
parent 1943f19b4e
commit 8e41b0a2ad
34 changed files with 1885 additions and 2081 deletions

View File

@@ -1,7 +1,3 @@
//CipherStreamJava/src/test/java/com/mattrixwv/cipherstream/polysubstitution/BifidTest.java
//Mattrixwv
// Created: 03-03-22
//Modified: 04-19-24
package com.mattrixwv.cipherstream.polysubstitution;
@@ -27,12 +23,12 @@ public class BifidTest{
@Mock
private Logger logger;
//Test
private static final String inputString = "Message to^encode";
private static final String inputStringClean = "MESSAGETOENCODE";
private static final String outputString = "Mqaokne kc^vdodzd";
private static final String outputStringClean = "MQAOKNEKCVDODZD";
private static final String keyword = "keyword";
private static final String keywordClean = "KEYWORDABCFGHILMNPQSTUVXZ";
private static final String INPUT_STRING = "Message to^encode";
private static final String INPUT_STRING_CLEAN = "MESSAGETOENCODE";
private static final String OUTPUT_STRING = "Mqaokne kc^vdodzd";
private static final String OUTPUT_STRING_CLEAN = "MQAOKNEKCVDODZD";
private static final String KEYWORD = "keyword";
private static final String KEYWORD_CLEAN = "KEYWORDABCFGHILMNPQSTUVXZ";
@Test
@@ -97,10 +93,10 @@ public class BifidTest{
@Test
public void testSetKeyword(){
cipher.setKeyword(keyword);
cipher.setKeyword(KEYWORD);
assertEquals(keyword, cipher.keyword);
verify(logger, times(1)).debug("Setting keyword '{}'", keyword);
assertEquals(KEYWORD, cipher.keyword);
verify(logger, times(1)).debug("Setting keyword '{}'", KEYWORD);
}
@Test
@@ -118,14 +114,14 @@ public class BifidTest{
cipher.preserveWhitespace = true;
cipher.preserveSymbols = true;
cipher.setInputString(inputString);
cipher.setInputString(INPUT_STRING);
assertEquals(inputString, cipher.inputString);
verify(logger, times(1)).debug("Original input string '{}'", inputString);
assertEquals(INPUT_STRING, cipher.inputString);
verify(logger, times(1)).debug("Original input string '{}'", INPUT_STRING);
verify(logger, never()).debug("Removing case");
verify(logger, never()).debug("Removing whitespace");
verify(logger, never()).debug("Removing symbols");
verify(logger, times(1)).debug("Cleaned input string '{}'", inputString);
verify(logger, times(1)).debug("Cleaned input string '{}'", INPUT_STRING);
}
@Test
@@ -134,14 +130,14 @@ public class BifidTest{
cipher.preserveWhitespace = true;
cipher.preserveSymbols = true;
cipher.setInputString(inputString);
cipher.setInputString(INPUT_STRING);
assertEquals(inputString.toUpperCase(), cipher.inputString);
verify(logger, times(1)).debug("Original input string '{}'", inputString);
assertEquals(INPUT_STRING.toUpperCase(), cipher.inputString);
verify(logger, times(1)).debug("Original input string '{}'", INPUT_STRING);
verify(logger, times(1)).debug("Removing case");
verify(logger, never()).debug("Removing whitespace");
verify(logger, never()).debug("Removing symbols");
verify(logger, times(1)).debug("Cleaned input string '{}'", inputString.toUpperCase());
verify(logger, times(1)).debug("Cleaned input string '{}'", INPUT_STRING.toUpperCase());
}
@Test
@@ -150,14 +146,14 @@ public class BifidTest{
cipher.preserveWhitespace = false;
cipher.preserveSymbols = true;
cipher.setInputString(inputString);
cipher.setInputString(INPUT_STRING);
assertEquals(inputString.replaceAll("\\s", ""), cipher.inputString);
verify(logger, times(1)).debug("Original input string '{}'", inputString);
assertEquals(INPUT_STRING.replaceAll("\\s", ""), cipher.inputString);
verify(logger, times(1)).debug("Original input string '{}'", INPUT_STRING);
verify(logger, never()).debug("Removing case");
verify(logger, times(1)).debug("Removing whitespace");
verify(logger, never()).debug("Removing symbols");
verify(logger, times(1)).debug("Cleaned input string '{}'", inputString.replaceAll("\\s", ""));
verify(logger, times(1)).debug("Cleaned input string '{}'", INPUT_STRING.replaceAll("\\s", ""));
}
@Test
@@ -166,14 +162,14 @@ public class BifidTest{
cipher.preserveWhitespace = true;
cipher.preserveSymbols = false;
cipher.setInputString(inputString);
cipher.setInputString(INPUT_STRING);
assertEquals(inputString.replaceAll("[^a-zA-Z\\s]", ""), cipher.inputString);
verify(logger, times(1)).debug("Original input string '{}'", inputString);
assertEquals(INPUT_STRING.replaceAll("[^a-zA-Z\\s]", ""), cipher.inputString);
verify(logger, times(1)).debug("Original input string '{}'", INPUT_STRING);
verify(logger, never()).debug("Removing case");
verify(logger, never()).debug("Removing whitespace");
verify(logger, times(1)).debug("Removing symbols");
verify(logger, times(1)).debug("Cleaned input string '{}'", inputString.replaceAll("[^a-zA-Z\\s]", ""));
verify(logger, times(1)).debug("Cleaned input string '{}'", INPUT_STRING.replaceAll("[^a-zA-Z\\s]", ""));
}
@Test
@@ -214,29 +210,29 @@ public class BifidTest{
@Test
public void testFormatOutput(){
cipher.inputString = inputString;
cipher.inputString = INPUT_STRING;
cipher.formatOutput(outputStringClean);
cipher.formatOutput(OUTPUT_STRING_CLEAN);
assertEquals(outputString, cipher.outputString);
assertEquals(OUTPUT_STRING, cipher.outputString);
verify(logger, times(1)).debug("Formatting output");
verify(logger, times(17)).debug(eq("Current character {}"), anyChar());
verify(logger, times(1)).debug("Altering uppercase");
verify(logger, times(14)).debug("Altering lowercase");
verify(logger, times(2)).debug("Adding symbol");
verify(logger, times(1)).debug("Formatted output string '{}'", outputString);
verify(logger, times(1)).debug("Formatted output string '{}'", OUTPUT_STRING);
}
@Test
public void testEncode(){
cipher.inputString = inputString;
cipher.keyword = keyword;
cipher.inputString = INPUT_STRING;
cipher.keyword = KEYWORD;
cipher.encode();
assertEquals(inputString, cipher.inputString);
assertEquals(keywordClean, cipher.keyword);
assertEquals(outputString, cipher.outputString);
assertEquals(INPUT_STRING, cipher.inputString);
assertEquals(KEYWORD_CLEAN, cipher.keyword);
assertEquals(OUTPUT_STRING, cipher.outputString);
verify(logger, times(1)).debug("Encoding");
verify(logger, times(1)).debug("Encoding Polybius");
verify(logger, times(1)).debug("Splitting Polybius Square message");
@@ -246,14 +242,14 @@ public class BifidTest{
@Test
public void testDecode(){
cipher.inputString = outputString;
cipher.keyword = keyword;
cipher.inputString = OUTPUT_STRING;
cipher.keyword = KEYWORD;
cipher.decode();
assertEquals(outputString, cipher.inputString);
assertEquals(keywordClean, cipher.keyword);
assertEquals(inputString, cipher.outputString);
assertEquals(OUTPUT_STRING, cipher.inputString);
assertEquals(KEYWORD_CLEAN, cipher.keyword);
assertEquals(INPUT_STRING, cipher.outputString);
verify(logger, times(1)).debug("Decoding");
verify(logger, times(1)).debug("Encoding Polybius Square");
verify(logger, times(1)).debug("Splitting Polybius Square message");
@@ -263,20 +259,20 @@ public class BifidTest{
@Test
public void testGetters(){
cipher.inputString = inputString;
cipher.keyword = keyword;
cipher.outputString = outputString;
cipher.inputString = INPUT_STRING;
cipher.keyword = KEYWORD;
cipher.outputString = OUTPUT_STRING;
assertEquals(inputString, cipher.getInputString());
assertEquals(keyword, cipher.getKeyword());
assertEquals(outputString, cipher.getOutputString());
assertEquals(INPUT_STRING, cipher.getInputString());
assertEquals(KEYWORD, cipher.getKeyword());
assertEquals(OUTPUT_STRING, cipher.getOutputString());
}
@Test
public void testReset(){
cipher.inputString = inputString;
cipher.keyword = keyword;
cipher.outputString = outputString;
cipher.inputString = INPUT_STRING;
cipher.keyword = KEYWORD;
cipher.outputString = OUTPUT_STRING;
cipher.reset();
@@ -290,11 +286,11 @@ public class BifidTest{
public void testPracticalEncoding(){
cipher = new Bifid(true, true, true);
String output = cipher.encode(keyword, inputString);
String output = cipher.encode(KEYWORD, INPUT_STRING);
assertEquals(inputString, cipher.inputString);
assertEquals(keywordClean, cipher.keyword);
assertEquals(outputString, cipher.outputString);
assertEquals(INPUT_STRING, cipher.inputString);
assertEquals(KEYWORD_CLEAN, cipher.keyword);
assertEquals(OUTPUT_STRING, cipher.outputString);
assertEquals(output, cipher.outputString);
}
@@ -302,35 +298,35 @@ public class BifidTest{
public void testPracticalEncoding_clean(){
cipher = new Bifid(false, false, false);
String output = cipher.encode(keyword, inputString);
String output = cipher.encode(KEYWORD, INPUT_STRING);
assertEquals(inputStringClean, cipher.inputString);
assertEquals(keywordClean, cipher.keyword);
assertEquals(outputStringClean, cipher.outputString);
assertEquals(outputStringClean, output);
assertEquals(INPUT_STRING_CLEAN, cipher.inputString);
assertEquals(KEYWORD_CLEAN, cipher.keyword);
assertEquals(OUTPUT_STRING_CLEAN, cipher.outputString);
assertEquals(OUTPUT_STRING_CLEAN, output);
}
@Test
public void testPracticalDecoding(){
cipher = new Bifid(true, true, true);
String output = cipher.decode(keyword, outputString);
String output = cipher.decode(KEYWORD, OUTPUT_STRING);
assertEquals(outputString, cipher.inputString);
assertEquals(keywordClean, cipher.keyword);
assertEquals(inputString, cipher.outputString);
assertEquals(inputString, output);
assertEquals(OUTPUT_STRING, cipher.inputString);
assertEquals(KEYWORD_CLEAN, cipher.keyword);
assertEquals(INPUT_STRING, cipher.outputString);
assertEquals(INPUT_STRING, output);
}
@Test
public void testPracticalDecoding_clean(){
cipher = new Bifid(false, false, false);
String output = cipher.decode(keyword, outputString);
String output = cipher.decode(KEYWORD, OUTPUT_STRING);
assertEquals(outputStringClean, cipher.inputString);
assertEquals(keywordClean, cipher.keyword);
assertEquals(inputStringClean, cipher.outputString);
assertEquals(inputStringClean, output);
assertEquals(OUTPUT_STRING_CLEAN, cipher.inputString);
assertEquals(KEYWORD_CLEAN, cipher.keyword);
assertEquals(INPUT_STRING_CLEAN, cipher.outputString);
assertEquals(INPUT_STRING_CLEAN, output);
}
}